feat: MMS-1868 new quote card and story #30303

ghgoodreau · 2025-02-13T16:32:00Z

Description

New quote card design for Solana cross-chain swaps.

integration blocked by dependencies, separate integration PR will come in the future, probably next week, to add it to the prepare-bridge page.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1868 (item no. 3)

Manual testing steps

Not relevant. Only on storybook for now. Component is not rendered anywhere in the app.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-13T16:32:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-13T17:12:05Z

Builds ready [999a599]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1685 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	367	2184	1608	364	175
		domContentLoaded	1407	2091	1670	231	111
		load	1415	2097	1685	234	112
		domInteractive	23	89	36	21	10
		backgroundConnect	8	69	18	15	7
		firstReactRender	15	71	40	23	11
		getState	4	64	12	15	7
		initialActions	0	1	0	0	0
		loadScripts	963	1547	1187	183	88
		setupStore	7	62	23	21	10
		uiStartup	1576	2415	1914	263	126

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-13T20:01:31Z

Builds ready [9a250c7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1793 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1537	2238	1800	176	84
		domContentLoaded	1485	2224	1771	173	83
		load	1537	2243	1793	170	82
		domInteractive	24	94	41	19	9
		backgroundConnect	8	56	22	14	7
		firstReactRender	14	68	27	18	9
		getState	5	68	19	20	10
		initialActions	0	1	0	0	0
		loadScripts	1052	1692	1308	148	71
		setupStore	6	60	24	22	10
		uiStartup	1785	2447	2037	172	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-14T01:24:45Z

Builds ready [b692619]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1941 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	314	2969	1847	458	220
		domContentLoaded	1594	2956	1912	306	147
		load	1632	2968	1941	301	145
		domInteractive	26	150	49	30	14
		backgroundConnect	10	81	34	21	10
		firstReactRender	15	73	38	21	10
		getState	5	62	21	19	9
		initialActions	0	0	0	0	0
		loadScripts	1098	2318	1413	262	126
		setupStore	7	52	16	12	6
		uiStartup	1837	3461	2244	346	166

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-14T23:32:15Z

Builds ready [ab76395]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1919 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	362	2335	1844	388	186
		domContentLoaded	1626	2289	1884	180	86
		load	1675	2365	1919	189	91
		domInteractive	25	119	44	25	12
		backgroundConnect	10	79	38	22	11
		firstReactRender	15	74	38	26	12
		getState	6	61	28	20	10
		initialActions	0	1	0	0	0
		loadScripts	1170	1704	1371	143	68
		setupStore	8	84	17	18	8
		uiStartup	1978	2694	2219	195	94

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-19T16:30:15Z

Builds ready [b6bbe67]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1719 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	276	2005	1513	494	237
		domContentLoaded	1487	1987	1697	114	55
		load	1496	2004	1719	112	54
		domInteractive	24	84	39	19	9
		backgroundConnect	8	63	28	20	10
		firstReactRender	15	73	38	25	12
		getState	4	54	12	13	6
		initialActions	0	0	0	0	0
		loadScripts	1026	1508	1230	106	51
		setupStore	8	57	16	16	8
		uiStartup	1680	2352	1981	146	70

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

ghgoodreau added 2 commits February 13, 2025 10:21

feat: new quote card

eb180fc

feat: new quote card and story

999a599

ghgoodreau added the team-swaps label Feb 13, 2025

ghgoodreau added 2 commits February 13, 2025 13:24

chore: fix lint

38235af

Merge branch 'main' into MMS-1868-quote-card-standalone

9a250c7

Merge branch 'main' into MMS-1868-quote-card-standalone

b692619

ghgoodreau marked this pull request as ready for review February 14, 2025 00:52

ghgoodreau requested a review from a team as a code owner February 14, 2025 00:52

Merge branch 'main' into MMS-1868-quote-card-standalone

ab76395

GustavoRSSilva approved these changes Feb 19, 2025

View reviewed changes

micaelae approved these changes Feb 19, 2025

View reviewed changes

Merge branch 'main' into MMS-1868-quote-card-standalone

b6bbe67

ghgoodreau added this pull request to the merge queue Feb 19, 2025

Merged via the queue into main with commit 03c5f58 Feb 19, 2025
79 checks passed

ghgoodreau deleted the MMS-1868-quote-card-standalone branch February 19, 2025 18:36

github-actions bot locked and limited conversation to collaborators Feb 19, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: MMS-1868 new quote card and story #30303

feat: MMS-1868 new quote card and story #30303

ghgoodreau commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 14, 2025

metamaskbot commented Feb 14, 2025

metamaskbot commented Feb 19, 2025

feat: MMS-1868 new quote card and story #30303

feat: MMS-1868 new quote card and story #30303

Conversation

ghgoodreau commented Feb 13, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 13, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 14, 2025

metamaskbot commented Feb 14, 2025

metamaskbot commented Feb 19, 2025

ghgoodreau commented Feb 13, 2025 •

edited

Loading